Ref: Simplified scene breadcrumbs messages

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## Unreleased
 
+- Simplified scene breadcrumbs messages ([#197](https://github.com/getsentry/sentry-unity/pull/197))
 - Check/create directory before saving ([#196](https://github.com/getsentry/sentry-unity/pull/196))
 - Embedded link.xml in assembly ([#194](https://github.com/getsentry/sentry-unity/pull/194))
 - Exclude SentryOptions.json from release package ([#195](https://github.com/getsentry/sentry-unity/pull/195))

src/Sentry.Unity/Integrations/SceneManagerIntegration.cs

@@ -16,7 +16,7 @@ public SceneManagerIntegration() : this(SceneManagerAdapter.Instance)
 
         public void Register(IHub hub, SentryOptions options)
         {
-            options.DiagnosticLogger?.Log(SentryLevel.Debug, "Registering BeforeSceneLoad integration.");
+            options.DiagnosticLogger?.Log(SentryLevel.Debug, "Registering SceneManager integration.");
 
             _sceneManager.SceneLoaded += OnSceneManagerOnSceneLoaded;
             _sceneManager.SceneUnloaded += SceneManagerOnSceneUnloaded;
@@ -32,15 +32,15 @@ void OnSceneManagerOnSceneLoaded(SceneAdapter scene, LoadSceneMode mode)
 
                 hub.AddBreadcrumb(
                     $"Scene '{scene.Name}' was loaded",
-                    category: "scene.loaded",
+                    category: "scene.loaded"
                     // TODO: What is worth paying the price of allocation in order to add here?
-                    data: new Dictionary<string, string>
-                    {
-                        {"name", scene.Name},
+                    // data: new Dictionary<string, string>
+                    // {
+                        // {"name", scene.Name},
                         // TODO: Should we benchmark before getting these? Are these and/or other unused fields useful?
                         // {"path", scene.path},
                         // {"isDirty", scene.isDirty.ToString()},
-                    }
+                    // }
                     // TODO: Is this useful? Does it happen that IsValid returns false at runtime?
                     // level: scene.IsValid()
                     //     ? BreadcrumbLevel.Error
@@ -58,11 +58,8 @@ void SceneManagerOnSceneUnloaded(SceneAdapter scene)
 
                 hub.AddBreadcrumb(
                     $"Scene '{scene.Name}' was unloaded",
-                    category: "scene.unloaded",
-                    data: new Dictionary<string, string>
-                    {
-                        {"name", scene.Name},
-                    });
+                    category: "scene.unloaded"
+                );
             }
 
             void SceneManagerOnActiveSceneChanged(SceneAdapter fromScene, SceneAdapter toScene)
@@ -73,9 +70,16 @@ void SceneManagerOnActiveSceneChanged(SceneAdapter fromScene, SceneAdapter toSce
                     return;
                 }
 
+                var message = $"Changed active scene '{fromScene.Name}' to '{toScene.Name}'";
+                if (fromScene.Name == null)
+                {
+                    message = $"Changed active scene to '{toScene.Name}'";
+                }
+
                 hub.AddBreadcrumb(
-                    $"Changed active scene '{fromScene.Name}' to '{toScene.Name}'",
-                    category: "scene.changed");
+                    message,
+                    category: "scene.changed"
+                );
             }
         }
     }

test/Sentry.Unity.Tests/SceneManagerIntegrationTests.cs

@@ -39,7 +39,6 @@ public void SceneLoaded_EnabledHub_CrumbAdded()
 
             Assert.AreEqual($"Scene '{sceneName}' was loaded", actualCrumb.Message);
             Assert.AreEqual("scene.loaded", actualCrumb.Category);
-            Assert.AreEqual(sceneName, actualCrumb.Data!["name"]);
         }
 
         [Test]
@@ -72,7 +71,6 @@ public void SceneUnloaded_EnabledHub_CrumbAdded()
 
             Assert.AreEqual($"Scene '{sceneName}' was unloaded", actualCrumb.Message);
             Assert.AreEqual("scene.unloaded", actualCrumb.Category);
-            Assert.AreEqual(sceneName, actualCrumb.Data!["name"]);
         }
 
         [Test]