Fix: Add product name to release as default #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
| @@ -32,7 +32,8 @@ public static void Init(SentryUnityOptions unitySentryOptions) | |||
| // Uses the game `version` as Release unless the user defined one via the Options | |||
| if (unitySentryOptions.Release == null) | |||
| { | |||
| unitySentryOptions.Release = Application.productName + "@" + Application.version; | |||
| unitySentryOptions.Release = $"{Application.productName}@{Application.version}"; | |||
There was a problem hiding this comment.
Just realized something: Can productName be null or an empty string? We might want to check for that before appending @
There was a problem hiding this comment.
It can not be null or empty. But it could be just a whitespace. To what should we default in that case? Just the version number without the @?
There was a problem hiding this comment.
yeah, we only append the @ if there's a string to its left. But if users are 'forced' to set something it's more of an edge case and not a huge deal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release should be
productName@versionif it's not overwritten by the user.