Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hub.IsEnabled check in logging integration #210

Merged
merged 7 commits into from
Jun 10, 2021
Merged

Hub.IsEnabled check in logging integration #210

merged 7 commits into from
Jun 10, 2021

Conversation

semuserable
Copy link
Contributor

closes #193

@semuserable
Copy link
Contributor Author

Currently in draft stage, because of several things:

  • waiting for Sentry .NET release to point submodule to a release and not a random commit
  • trying to do tests

@semuserable semuserable marked this pull request as ready for review June 8, 2021 15:35
@semuserable
Copy link
Contributor Author

updated, sync with main, no more submodule changes

cc @bruno-garcia @bitsandfoxes

@bruno-garcia bruno-garcia merged commit 5de7d62 into main Jun 10, 2021
@bruno-garcia bruno-garcia deleted the bug/hub-is-enabled branch June 10, 2021 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-garcia bruno-garcia bruno-garcia approved these changes

@bitsandfoxes bitsandfoxes Awaiting requested review from bitsandfoxes bitsandfoxes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@semuserable @bruno-garcia