Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Un-Embedding the link.xml #237

Merged
merged 6 commits into from
Jun 23, 2021
Merged

Un-Embedding the link.xml #237

merged 6 commits into from
Jun 23, 2021

Conversation

bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Jun 23, 2021 •
edited
Loading

What happened so far:

  1. Initially link.xml was inside Resources/Sentry and got shipped with the build
  2. Wanted to move it somewhere else. Can't be inside /Packages because the managed code stripper doesn't look there.
  3. Embedded it into the assembly. But that doesn't work with a wide range of Unity versions.
  4. Placing it now in Assets/Plugins/Sentry

@bitsandfoxes bitsandfoxes added the Bug Something isn't working label Jun 23, 2021
@bitsandfoxes bitsandfoxes self-assigned this Jun 23, 2021
@bitsandfoxes bitsandfoxes mentioned this pull request Jun 23, 2021
Closed
@bitsandfoxes bitsandfoxes marked this pull request as ready for review June 23, 2021 14:38
@bitsandfoxes bitsandfoxes linked an issue Jun 23, 2021 that may be closed by this pull request
Logging not working on the Android device #236
Closed
semuserable
semuserable approved these changes Jun 23, 2021
View reviewed changes
src/Sentry.Unity.Editor/SentryPreprocessBuild.cs Outdated Show resolved Hide resolved
src/Sentry.Unity.Editor/SentryWindow.cs Outdated Show resolved Hide resolved
src/Sentry.Unity.Editor/SentryWindow.cs Outdated Show resolved Hide resolved
bruno-garcia
bruno-garcia approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bitsandfoxes bitsandfoxes merged commit 0c909ef into main Jun 23, 2021
@bitsandfoxes bitsandfoxes deleted the fix/linkxml branch June 23, 2021 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-garcia bruno-garcia bruno-garcia approved these changes

@semuserable semuserable semuserable approved these changes

Assignees

@bitsandfoxes bitsandfoxes

Labels
Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logging not working on the Android device
3 participants
@bitsandfoxes @bruno-garcia @semuserable