Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Importing link.xml instead of refreshing AssetDatabase #315

Merged
merged 4 commits into from
Sep 17, 2021

Conversation

bitsandfoxes
Copy link
Contributor

Fixes: #265
Instead of creating the file in OnEnable and (possibly) triggering an entire AssetDatabase refresh that ends up in an endless loop we just import that one XML.

Fixed the weird formatting that happened a couple of PRs earlier as well, sry for the noise.

@bitsandfoxes bitsandfoxes self-assigned this Sep 16, 2021
@bitsandfoxes bitsandfoxes changed the title fix: Importing link.xml instead of refreshing entire assetdatabase fix: Importing link.xml instead of refreshing entire AssetDatabase Sep 16, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
@bruno-garcia bruno-garcia changed the title fix: Importing link.xml instead of refreshing entire AssetDatabase fix: Importing link.xml instead of refreshing AssetDatabase Sep 17, 2021
@bruno-garcia bruno-garcia merged commit 3f00c98 into main Sep 17, 2021
@bruno-garcia bruno-garcia deleted the fix/link-xml-import-error branch September 17, 2021 14:08
@github-actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Importing link.xml instead of refreshing AssetDatabase ([#315](https://github.com/getsentry/sentry-unity/pull/315))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 8ce9f8f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors on new install
2 participants