fix: Validating options before SDK init #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitsandfoxes
changed the title
bitsandfoxes
changed the title
marandaneto
reviewed
Oct 15, 2021
marandaneto
reviewed
Oct 15, 2021
bruno-garcia
approved these changes
Oct 17, 2021
marandaneto
approved these changes
Oct 18, 2021
SimonCropp
reviewed
Oct 18, 2021
| /// <param name="unitySentryOptionsConfigure">Callback to configure the options.</param> | ||
| public static void Init(Action<SentryUnityOptions> unitySentryOptionsConfigure) | ||
| /// <param name="sentryUnityOptionsConfigure">Callback to configure the options.</param> | ||
| public static void Init(Action<SentryUnityOptions> sentryUnityOptionsConfigure) |
There was a problem hiding this comment.
note that this is a breaking change if someone is using named parameters
There was a problem hiding this comment.
That's actually a very good point. Thanks for pointing it out. Did not consider that at all.
There was a problem hiding this comment.
That's good to keep in mind. But since we're on 0.x version and adoption is still low, we can go ahead with it here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #371
CaptureInEditor is a Unity-specific flag and has to be checked before passing the options to the .NET SDK.