Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Automated symbols upload for iOS w/ bitcode #443

Merged
merged 10 commits into from
Dec 2, 2021

Conversation

bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Dec 1, 2021

Things this PR aims to accomplish:

  1. Adding a sentry.properties to the Xcode project
  2. Adding the sentry-cli executable to the Xcode project (this way we make sure the Xcode project does not rely on a file located inside a Unity package e.g. exporting on Windows and building on a mac)
  3. Appending a shellscript to the build phases that checks for the bitcode flag and runs sentry-cli at the appropriate path

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2021

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 5afef86

@bruno-garcia bruno-garcia reopened this Dec 2, 2021
@bruno-garcia
Copy link
Member

Closed/reopen to trigger CI again. It had only passed "Danger"

src/Sentry.Unity.Editor.iOS/SentryXcodeProject.cs Outdated Show resolved Hide resolved
src/Sentry.Unity.Editor.iOS/SentryXcodeProject.cs Outdated Show resolved Hide resolved
src/Sentry.Unity.Editor.iOS/SentryXcodeProject.cs Outdated Show resolved Hide resolved
@bitsandfoxes bitsandfoxes merged commit 38b0f79 into main Dec 2, 2021
@bitsandfoxes bitsandfoxes deleted the feat/ios-symbol-upload branch December 2, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants