Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Symbol upload requires IL2CPP #450

Merged
merged 5 commits into from
Dec 7, 2021
Merged

Conversation

bitsandfoxes
Copy link
Contributor

With automatic symbols upload enabled and scripting backend not IL2CPP we currently break builds because we're looking for symbol files that don't exist.
That and we were missing a bunch of upload feature related tests.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit otherwise LGTM

@bitsandfoxes bitsandfoxes merged commit b540698 into main Dec 7, 2021
@bitsandfoxes bitsandfoxes deleted the fix/android-scripting-backend branch December 7, 2021 13:38
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2021

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Symbol upload requires IL2CPP ([#450](https://github.com/getsentry/sentry-unity/pull/450))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 45ce0f6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants