Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Editor support for options configuration #569

Merged
merged 6 commits into from
Feb 23, 2022

Conversation

bitsandfoxes
Copy link
Contributor

The goal is to have the least amount of steps between the config window and a user that just wants to write code.
The added options config tab allows the user to add the scriptable object that gets called during runtime initialization.
The button does:

  1. Creates a script from a template at a user-selected location
  2. Instantiates the scriptable object from the script and assigns it

Multiple button clicks allow for replacing of the script.
Already assigned scriptable objects do not get overwritten in the config window.
OptionsConfiguration

@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2022

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Editor support for options configuration ([#569](https://github.com/getsentry/sentry-unity/pull/569))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 143fdd8

@bruno-garcia
Copy link
Member

Is this ready to be merged? We can merge the docs PR after this

…onTab.cs

Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
@bitsandfoxes bitsandfoxes merged commit 1e043f6 into main Feb 23, 2022
@bitsandfoxes bitsandfoxes deleted the feat/extend-program-init branch February 23, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants