Feat: windows symbol upload #607
Conversation
| // addPath(Path.GetFileNameWithoutExtension(executableName) + "_Data/Plugins/x86_64/sentry.dll"); | ||
|
|
||
| // Configure the process using the StartInfo properties. | ||
| var process = new Process |
There was a problem hiding this comment.
Ideally, we would like to avoid spawning a blocking process from within the Unity editor and call Sentry CLI from a msbuild target during the build.
There was a problem hiding this comment.
maybe an option after I figure out how to inject into the IL2CPP windows build. For "project-only" builds where unity itself doesn't compile the binaries it would also be the only option.
There was a problem hiding this comment.
While @bitsandfoxes is working on the integration into the unity build process for standalone windows, I'd say this PR still makes sense to merge as is now? Already brings support for the "build-in-unity" workflow
| } | ||
| }; | ||
|
|
||
| addPath(executableName); |
There was a problem hiding this comment.
Aren't we better off running sentry-cli on the root and let it find the relevant files? It'll also be more future proof if Unity introduces other native shared libraries
There was a problem hiding this comment.
I've thought about that but didn't like that it would also upload:
- UnityCrashHandler64.exe
- crashpad_handler.exe
There was a problem hiding this comment.
Do you mean it uploads the executables? My understanding was that upload-dif would only scan for and upload debug information files.
There was a problem hiding this comment.
executables also have some debug info. See for example here:
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
Part of windows native support #527