chore: update CLI to v2.2.0 #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaind
force-pushed
the
chore/sentry-cli-2.2.0
branch
from
e5a97e6
to
97c9cf2
Compare
| @@ -181,8 +182,30 @@ private static void UploadDebugSymbols(IDiagnosticLogger logger, BuildTarget tar | |||
| process.StartInfo.EnvironmentVariables["SENTRY_ORG"] = cliOptions.Organization; | |||
| process.StartInfo.EnvironmentVariables["SENTRY_PROJECT"] = cliOptions.Project; | |||
| process.StartInfo.EnvironmentVariables["SENTRY_AUTH_TOKEN"] = cliOptions.Auth; | |||
| process.OutputDataReceived += (sender, args) => logger.LogDebug($"sentry-cli: {args.Data.ToString()}"); | |||
| process.ErrorDataReceived += (sender, args) => logger.LogError($"sentry-cli: {args.Data.ToString()}"); | |||
| process.StartInfo.EnvironmentVariables["SENTRY_LOG_LEVEL"] = "info"; | |||
There was a problem hiding this comment.
Shouldn't this be based on the options? If Debug=true we add it, based on the DiagnosticLevel?
There was a problem hiding this comment.
We forward it through the logger (below), with the level parsed from the CLI output, and let that decide whether to print or not, depending on the configuration.
bitsandfoxes
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #674