fix: use LogWarning instead of LogError for potential SDK errors #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaind
commented
Jun 30, 2022
vaind
commented
Jun 30, 2022
vaind
commented
Jun 30, 2022
bruno-garcia
approved these changes
Jul 5, 2022
|
Actually. Does it make sense to be an error? We'd like to warn the user that somethjing went wrong here so we can be aware |
It does make sense, that's why it was an error. Whether it should still be is up to you. See #747 (comment) update: clarified now - we will add a "Sentry: " prefix to avoid sending the error but still log it as LogError |
bitsandfoxes
approved these changes
Jul 5, 2022
bitsandfoxes
reviewed
Jul 5, 2022
| @@ -151,7 +151,8 @@ public ScopeCallback(Action<AndroidJavaObject> callback) : base("io.sentry.Scope | |||
| } | |||
| catch (Exception e) | |||
| { | |||
| UnityEngine.Debug.LogError($"Error in SentryJava.ScopeCallback: {e}"); | |||
| // Adding the Sentry logger prefix ensures we don't send this error to Sentry. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #839
#skip-changelog