Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Added a x64 guard to the IL2CPP methods #871

Merged
merged 7 commits into from
Jul 6, 2022
Merged

fix: Added a x64 guard to the IL2CPP methods #871

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
61f4749
stricter version restriction
bitsandfoxes Jul 6, 2022
aa0be70
only on 64
bitsandfoxes Jul 6, 2022
be673a8
updated CHANGELOG.md
bitsandfoxes Jul 6, 2022
4166cdb
fixed version
bitsandfoxes Jul 6, 2022
1a9ef9e
added 64 guard to sentry native
bitsandfoxes Jul 6, 2022
98d7dd4
final form
bitsandfoxes Jul 6, 2022
d48c53c
updated CHANGELOG.md
bitsandfoxes Jul 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## Unreleased

- Fixed linker issues for x86 IL2CPP builds on 2020.3 and newer ([#871](https://github.com/getsentry/sentry-unity/pull/871))
bitsandfoxes marked this conversation as resolved.
Show resolved Hide resolved

## 0.20.0

### Features
Expand Down
2 changes: 1 addition & 1 deletion package-dev/Runtime/SentryInitialization.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ public string Platform

private Il2CppMethods _il2CppMethods
// Lowest supported version to have all required methods below
#if !ENABLE_IL2CPP || !UNITY_2020_3_OR_NEWER
#if !ENABLE_IL2CPP || !UNITY_2020_3_OR_NEWER || !UNITY_64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a 32 bit Unity build to our CI?

;
#else
= new Il2CppMethods(
Expand Down