Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Additional editor window utility #910

Merged
merged 3 commits into from
Jul 27, 2022
Merged

feat: Additional editor window utility #910

merged 3 commits into from
Jul 27, 2022

Conversation

bitsandfoxes
Copy link
Contributor

Added logging and icon highlights.

Highlight if the DSN is missing since it's the most crucial/fundamental part of the config:
image

Checking if the symbol upload is properly setup to set expectations:
image

In Unity 2019:
image

Symbol Upload Highlights for the required fields (best effort without actual validation of the input):
Editor

@bitsandfoxes bitsandfoxes requested a review from vaind as a code owner July 26, 2022 13:54
@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2022

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 2c23471

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@bitsandfoxes bitsandfoxes merged commit 9b9b012 into main Jul 27, 2022
@bitsandfoxes bitsandfoxes deleted the feat/editor-util branch July 27, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants