Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: iOS native samples ObjectiveCPlugin #921

Merged
merged 3 commits into from
Jul 29, 2022
Merged

fix: iOS native samples ObjectiveCPlugin #921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37f2294
added the objective c plugin back into samples
bitsandfoxes Jul 29, 2022
2ca0155
plugin cleanup
bitsandfoxes Jul 29, 2022
2ec1608
Updated CHANGELOG.md
bitsandfoxes Jul 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

## Unreleased


### Fixes

- iOS samples were missing the Objective-C plugin ([#921](https://github.com/getsentry/sentry-unity/pull/921))
- Save SampleRate to Options.asset ([#916](https://github.com/getsentry/sentry-unity/pull/916))

### Features
Expand Down
19 changes: 19 additions & 0 deletions samples/unity-of-bugs/Assets/Scripts/NativeSupport/ObjectiveCPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
#import <Foundation/Foundation.h>

NS_ASSUME_NONNULL_BEGIN

void throwObjectiveC()
{
#ifdef __EXCEPTIONS
NSLog(@"Throwing an Objective-C Exception");
@throw [NSException exceptionWithName:@"Objective-C Exception"
reason:@"Sentry Unity Objective-C Support."
userInfo:nil];
#else
NSLog(@"Objective-C Exceptions are disabled. "
"Consider enabling it in the Xcode project: "
"GCC_ENABLE_OBJC_EXCEPTIONS");
#endif
}

NS_ASSUME_NONNULL_END
37 changes: 37 additions & 0 deletions samples/unity-of-bugs/Assets/Scripts/NativeSupport/ObjectiveCPlugin.m.meta
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions test/Scripts.Tests/package-release.zip.snapshot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,8 @@ Samples~/unity-of-bugs/Scripts/NativeSupport/NativeButtons.cs
Samples~/unity-of-bugs/Scripts/NativeSupport/NativeButtons.cs.meta
Samples~/unity-of-bugs/Scripts/NativeSupport/NativeSupportScene.cs
Samples~/unity-of-bugs/Scripts/NativeSupport/NativeSupportScene.cs.meta
Samples~/unity-of-bugs/Scripts/NativeSupport/ObjectiveCPlugin.m
Samples~/unity-of-bugs/Scripts/NativeSupport/ObjectiveCPlugin.m.meta
Samples~/unity-of-bugs/Scripts/NativeSupport/WebGLButtons.cs
Samples~/unity-of-bugs/Scripts/NativeSupport/WebGLButtons.cs.meta
CHANGELOG.md
Expand Down