Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the screenshot quality was relative to the current screen size which creates issues when a project supports a wide range of different resolutions, making "half the current resolution" on small screens barely usable.
Instead, we can map
High, Medium, Low
to "ranges" of resolutions akin to what Youtube videos offer.We take the wider side (portrait or landscape) and scale the screenshot to match while preserving the aspect ratio. (defacto @vaind's original implementation) with an user-facing enum instead of a
vec2 max resolution
.