Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Auto Instrumentation for Awake #998

Merged
merged 35 commits into from
Oct 28, 2022
Merged
Show file tree
Hide file tree
Changes from 32 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
a603788
wip
bitsandfoxes Oct 3, 2022
e3f8139
added success check, inserting finish before return
bitsandfoxes Oct 4, 2022
c293b8f
tweaking template scripts
bitsandfoxes Oct 4, 2022
ad04f9e
added so options flag, refactor, logging
bitsandfoxes Oct 4, 2022
0d24711
Merge branch 'main' into feat/awake-instrument
bitsandfoxes Oct 5, 2022
14b7a01
Merge branch 'main' into feat/awake-instrument
bitsandfoxes Oct 10, 2022
145a5b4
not relying on the static helper methods
bitsandfoxes Oct 11, 2022
0a9dae1
Format code
getsentry-bot Oct 11, 2022
2583e7f
wip
bitsandfoxes Oct 12, 2022
2f05950
refactor & hooking up to build process
bitsandfoxes Oct 12, 2022
42e95d7
Format code
getsentry-bot Oct 12, 2022
55e7932
integration test
bitsandfoxes Oct 14, 2022
c906847
Merge branch 'feat/awake-instrument' of https://github.com/getsentry/…
bitsandfoxes Oct 14, 2022
317d872
Merge branch 'main' into feat/awake-instrument
bitsandfoxes Oct 14, 2022
ab1bd1b
Updated CHANGELOG.md
bitsandfoxes Oct 14, 2022
e4feebe
Merge branch 'main' into feat/awake-instrument
bitsandfoxes Oct 17, 2022
9537317
logging assembly output path
bitsandfoxes Oct 17, 2022
5f51ac4
disabling self initialization for integration tests
bitsandfoxes Oct 17, 2022
05a05b6
fixed compilation hookup
bitsandfoxes Oct 17, 2022
197f8ea
refactor & CI logging
bitsandfoxes Oct 18, 2022
fa87f7b
widening the search for Assembly-CSharp
bitsandfoxes Oct 18, 2022
f6cad9b
Merge branch 'main' into feat/awake-instrument
bitsandfoxes Oct 18, 2022
99ecb14
expected symbol count for android
bitsandfoxes Oct 18, 2022
3a28272
enable startup tracing for 2019
bitsandfoxes Oct 18, 2022
0b66d6f
android expected symbol cound tweak?
bitsandfoxes Oct 19, 2022
8fe6583
logging
bitsandfoxes Oct 19, 2022
4b5051b
skipping until transaction event
bitsandfoxes Oct 19, 2022
015b605
updated snapshot
bitsandfoxes Oct 19, 2022
ba75574
Merge branch 'main' into feat/awake-instrument
bitsandfoxes Oct 19, 2022
df0e9d8
updated snapshot
bitsandfoxes Oct 20, 2022
445e0e8
merged main
bitsandfoxes Oct 21, 2022
18b290b
updated configure-sentry for new ci
bitsandfoxes Oct 21, 2022
4629323
review points
bitsandfoxes Oct 27, 2022
00ab99c
Merge branch 'main' into feat/awake-instrument
bitsandfoxes Oct 27, 2022
6b08bf1
Updated CHANGELOG.md
bitsandfoxes Oct 27, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

### Features

- Automated Performance Instrumentation for MonoBehaviour.Awake methods ([#998](https://github.com/getsentry/sentry-unity/pull/998))
- The Cocoa SDK is now bundled as `.xcframework` ([#1002](https://github.com/getsentry/sentry-unity/pull/1002))
- Automated Performance Instrumentation for Runtime Initialization ([#991](https://github.com/getsentry/sentry-unity/pull/991))
- Automated Performance Instrumentation for Scene Loading ([#768](https://github.com/getsentry/sentry-unity/pull/768))
Expand Down
7 changes: 5 additions & 2 deletions package-dev/Runtime/SentryIntegrations.cs
Original file line number Diff line number Diff line change
Expand Up @@ -19,20 +19,23 @@ public static class SentryIntegrations
{
public static void Configure(SentryUnityOptions options)
{
#if SENTRY_SCENE_MANAGER_TRACING_INTEGRATION
if (options.TracesSampleRate > 0.0)
{
// On WebGL the SDK initializes on BeforeScene so the Startup Tracing won't work properly. https://github.com/getsentry/sentry-unity/issues/1000
#if !SENTRY_WEBGL
options.AddIntegration(new StartupTracingIntegration());
#endif
#if SENTRY_SCENE_MANAGER_TRACING_INTEGRATION
options.AddIntegration(new SceneManagerTracingIntegration());
#endif
}
else
{
#if SENTRY_SCENE_MANAGER_TRACING_INTEGRATION
options.DiagnosticLogger?.LogDebug("Skipping SceneManagerTracing integration because performance tracing is disabled.");
}
#endif
}

}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ MonoBehaviour:
<CaptureInEditor>k__BackingField: 1
<EnableLogDebouncing>k__BackingField: 0
<TracesSampleRate>k__BackingField: 0
<AutoInstrumentPerformance>k__BackingField: 0
<AutoSessionTracking>k__BackingField: 1
<AutoSessionTrackingInterval>k__BackingField: 30000
<ReleaseOverride>k__BackingField:
Expand Down
Loading