Skip to content

Commit

Permalink
feat(devserver): Run separate transactions post process forwarder (#4…
Browse files Browse the repository at this point in the history
…0130)

Combined post process forwarder no longer works with Sentry/Snuba
defaults (fully separated errors/transactions topics).

Running a combined PPF caused this error in self hosted:
#40120.

In the future it may be nice to support a PPF implementation that can
consume from multiple topics in order to reduce the amount of docker
containers in dev / low volume environments but this is not currently
possible.
  • Loading branch information
lynnagara authored Oct 17, 2022
1 parent 2069c2c commit cf472c7
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion src/sentry/runner/commands/devserver.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,22 @@
"sentry",
"run",
"post-process-forwarder",
"--entity=all",
"--entity=errors",
"--loglevel=debug",
"--commit-batch-size=100",
"--commit-batch-timeout-ms=1000",
],
"post-process-forwarder-transactions": [
"sentry",
"run",
"post-process-forwarder",
"--entity=transactions",
"--loglevel=debug",
"--commit-batch-size=100",
"--commit-batch-timeout-ms=1000",
"--commit-log-topic=snuba-transactions-commit-log",
"--synchronize-commit-group=transactions_group",
],
"ingest": ["sentry", "run", "ingest-consumer", "--all-consumer-types"],
"region_to_control": ["sentry", "run", "region-to-control-consumer", "--region-name", "_local"],
"server": ["sentry", "run", "web"],
Expand Down Expand Up @@ -250,6 +261,7 @@ def devserver(

if eventstream.requires_post_process_forwarder():
daemons += [_get_daemon("post-process-forwarder")]
daemons += [_get_daemon("post-process-forwarder-transactions")]

if settings.SENTRY_EXTRA_WORKERS:
daemons.extend([_get_daemon(name) for name in settings.SENTRY_EXTRA_WORKERS])
Expand Down

0 comments on commit cf472c7

Please sign in to comment.