ref(slack): Use conversations.list for bot apps #20047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MeredithAnya
commented
Jul 27, 2020
| @@ -423,7 +422,13 @@ def get_channel_id_with_timeout(integration, name, timeout): | |||
| # Look for channel ID | |||
| payload = dict(token_payload, **{"exclude_archived": False, "exclude_members": True}) | |||
|
|
|||
| if options.get("slack.legacy-app") is True: | |||
| default_install_type = ( | |||
There was a problem hiding this comment.
@scefali going to update to use what you have in your PR
MeredithAnya
force-pushed
the
slack/ISSUE-921
branch
from
c94f793 to
1c13651
Compare
scefali
reviewed
Jul 28, 2020
| @@ -423,7 +429,9 @@ def get_channel_id_with_timeout(integration, name, timeout): | |||
| # Look for channel ID | |||
| payload = dict(token_payload, **{"exclude_archived": False, "exclude_members": True}) | |||
|
|
|||
| if options.get("slack.legacy-app") is True: | |||
There was a problem hiding this comment.
@MeredithAnya You can remove all instances of this setting since this is the only use case of it
There was a problem hiding this comment.
heck I guess that means removing the docs on it too? Thinking about it again, is there any case that this check wouldn't pass for sentry on-prem?
There was a problem hiding this comment.
@MeredithAnya I wouldn't remove it from the docs yet because you'll need it if you have the last version. It doesn't hurt to set it even if we don't use it (we can remove it in the future at some point). This check should work fine for on-prem.
scefali
approved these changes
Jul 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not too long ago a PR was merged that added the option
slack.legacy-app. This allows Sentry instances with that option set toFalseto be able to utilize the conversations.list endpoint for Slack.Sentry.io however, must have this option set to
Truebecause there are still users that have workspace apps enable and in use. We cannot use the conversations endpoints with the workspace apps because the workspace token is incompatible.Instead, we can look at the integration
metadatato tell us whether or not an integration is a workspace app in order to determine which set of endpoints to use.