Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Test react v17rc #20803

Closed
wants to merge 1 commit into from
Closed

chore: Test react v17rc #20803

wants to merge 1 commit into from

Conversation

matejminar
Copy link
Member

#test-getsentry

@matejminar matejminar requested a review from a team as a code owner September 16, 2020 10:00
@github-actions
Copy link
Contributor

github-actions bot commented Sep 16, 2020 •
edited
Loading

size-limit report

Path Size
public/app.js 234.75 KB (0%)
public/vendor.js 446.04 KB (+0.36% 🔺)

@matejminar
Copy link
Member Author

Looks like there is some sort of a problem with mounting in tests, but I didn't have time to study it into greater detail.

@billyvg
Copy link
Member

billyvg commented Sep 16, 2020 •
edited
Loading

Looks like

sentry/src/sentry/static/sentry/app/stores/tooltipStore.tsx

Line 21 in 0edc7c1

!(tooltip as any)._reactInternalFiber.key &&
is a culprit cc @k-fish

(internals were renamed facebook/react#18377)

@billyvg billyvg removed the request for review from a team September 16, 2020 17:23
@billyvg
Copy link
Member

billyvg commented Sep 16, 2020

Our jest tests will be blocked by enzymejs/enzyme#2429

@k-fish
Copy link
Member

k-fish commented Sep 16, 2020

@billyvg damn, thought I'd have more than a few weeks before using internals bit me 😄. If we merge in #20825 I think we should be fine on either side of the upgrade (if I'm reading the changes correctly).

@matejminar matejminar added the Do Not Merge Don't merge label Sep 17, 2020
@billyvg billyvg force-pushed the chore/test-react-17rc branch from efac188 to 7c5491a Compare September 17, 2020 21:00
@billyvg billyvg marked this pull request as draft October 8, 2020 17:50
@matejminar matejminar closed this Oct 16, 2020
@matejminar matejminar deleted the chore/test-react-17rc branch December 9, 2020 18:01
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Do Not Merge Don't merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matejminar @billyvg @k-fish