Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spans): Add span metrics in new namespace #50718

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

iker-barriocanal
Copy link
Contributor

Now that the new spans namespace is available, we're moving the span metrics from the transactions namespace to the spans namespace.

The namespace is registered here.

@iker-barriocanal iker-barriocanal requested a review from a team June 12, 2023 11:03
@iker-barriocanal iker-barriocanal self-assigned this Jun 12, 2023
@iker-barriocanal iker-barriocanal requested a review from a team as a code owner June 12, 2023 11:03
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 12, 2023
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #50718 (5bc5ddc) into master (a49d9ad) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #50718      +/-   ##
==========================================
- Coverage   81.16%   81.16%   -0.01%     
==========================================
  Files        4861     4861              
  Lines      203828   203828              
  Branches    11159    11159              
==========================================
- Hits       165443   165439       -4     
- Misses      38139    38143       +4     
  Partials      246      246              
Impacted Files Coverage Δ
src/sentry/sentry_metrics/indexer/strings.py 100.00% <ø> (ø)

... and 3 files with indirect coverage changes

@iker-barriocanal iker-barriocanal merged commit 6f8b6cb into master Jun 12, 2023
@iker-barriocanal iker-barriocanal deleted the iker/feat/span-metrics-spans-namespace branch June 12, 2023 11:51
@github-actions github-actions bot locked and limited conversation to collaborators Jun 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants