ref(superuser): red sidebar for active superuser #61329
Conversation
github-actions
bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
src/sentry/conf/server.py
Outdated
| @@ -2392,6 +2392,7 @@ def custom_parameter_sort(parameter: dict) -> tuple[str, int]: | |||
| "openid", | |||
| "profile", | |||
| "email", | |||
| "org:superuser", | |||
There was a problem hiding this comment.
Let's move this up next to the org:* scopes, and add a comment that this is only for superusers and it is added when the superuser session is valid.
There was a problem hiding this comment.
i'm going to isolate the FE from BE changes and do the FE first in this PR
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #61329 +/- ##
==========================================
- Coverage 81.08% 81.08% -0.01%
==========================================
Files 5186 5186
Lines 227817 227813 -4
Branches 38221 38221
==========================================
- Hits 184720 184715 -5
Misses 37471 37471
- Partials 5626 5627 +1
|
cathteng
removed
the
Scope: Backend
cathteng
changed the title
| @@ -973,6 +974,7 @@ export const darkTheme: Theme = { | |||
| }, | |||
| sidebarGradient: `linear-gradient(180deg, ${sidebarBackground.dark} 0%, #1B1825 100%)`, | |||
| sidebarBorder: darkAliases.border, | |||
| superuserSidebar: '#620808', | |||
There was a problem hiding this comment.
Nit: All other sidebar-related keys started with the word "sidebar"
| superuserSidebar: '#620808', | |
| sidebarColorSuperuser: '#620808', |
|
I think the sidebar should not be red if the user is also the organization owner. On self-hosted most of the time the org-owner is also super admin. |
When superuser is active or superuser is required to access an org, the sidebar will turn red.
Backend changes to come to add the scope
org:superusertorequest.accessfor active superuser.red-superuser-bar.mov