Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(feedback): add JS-adjacent platforms to issues feedback sidebar #66478

Merged
merged 5 commits into from
Mar 7, 2024
Merged

feat(feedback): add JS-adjacent platforms to issues feedback sidebar #66478

merged 5 commits into from
Mar 7, 2024

Conversation

michellewzhang
Copy link
Member

@michellewzhang michellewzhang commented Mar 6, 2024 •
edited
Loading

  • these platforms all use the same structure as the JavaScript onboarding
  • all have the widget callout

this PR adds the instructions for

  • bun
  • capacitor
  • ember
  • angular
  • astro
  • gatsby
  • nextjs
  • react
  • remix
  • svelte
  • sveltekit
  • vue
  • ionic
SCR-20240306-nwaf

relates to #66162

@michellewzhang michellewzhang requested review from a team as code owners March 6, 2024 22:57
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 6, 2024
@michellewzhang michellewzhang changed the title feat(feedback): [1/3] JS: add platforms to issues feedback sidebar feat(feedback): add JS-adjacent platforms to issues feedback sidebar Mar 6, 2024
@michellewzhang michellewzhang requested a review from a team March 6, 2024 23:39
billyvg
billyvg approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URLs look like they match up

@michellewzhang michellewzhang merged commit acaa0b8 into master Mar 7, 2024
43 checks passed
@michellewzhang michellewzhang deleted the mz/onb-js-1 branch March 7, 2024 19:36
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@billyvg billyvg billyvg approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michellewzhang @billyvg