feat(ci): Add coverage and junit results for js #6929
Conversation
.babelrc.js
Outdated
| 'transform-decorators-legacy', | ||
| 'transform-class-properties', | ||
| 'transform-object-rest-spread', | ||
| 'transform-runtime', |
There was a problem hiding this comment.
without this i got weird import errors on some tests
.babelrc.js
Outdated
| [ | ||
| 'babel-plugin-transform-builtin-extend', | ||
| { | ||
| globals: ['Array', 'Error'], |
There was a problem hiding this comment.
i added Error here for no good reason other than I use it in Zeus and its nice to be able to extend it and maintain the type
scripts/config/env.js
Outdated
| @@ -0,0 +1,58 @@ | |||
| 'use strict'; | |||
scripts/test.js
Outdated
| throw err; | ||
| }); | ||
|
|
||
| // Ensure environment variables are read. |
There was a problem hiding this comment.
this include can be removed
Generated by 🚫 danger |
package.json
Outdated
| "collectCoverage": true, | ||
| "collectCoverageFrom": [ | ||
| "tests/js/spec/**/*.{js,jsx}", | ||
| "src/sentry/static/sentry/**/*.{js,jsx}" |
There was a problem hiding this comment.
should this be src/sentry/static/sentry/app/**/*.{js,jsx}?
package.json
Outdated
| "lint": "node_modules/.bin/eslint tests/js src/sentry/static/sentry/app --ext .jsx", | ||
| "dev-proxy": "node scripts/devproxy.js", | ||
| "dev-server": "webpack-dev-server", | ||
| "storybook": "start-storybook -p 9001 -c .storybook", | ||
| "snapshot": "build-storybook && PERCY_TOKEN=$STORYBOOK_PERCY_TOKEN PERCY_PROJECT=$STORYBOOK_PERCY_PROJECT percy-storybook --widths=375,1280" | ||
| }, | ||
| "jest": { | ||
| "collectCoverage": true, |
There was a problem hiding this comment.
This should be removed, and instead we pass --coverage into test-ci tasl
package.json
Outdated
| "jest": "NODE_ENV=test node_modules/.bin/jest", | ||
| "jest-debug": "NODE_ENV=test node --inspect-brk node_modules/.bin/jest --runInBand", | ||
| "test": "node scripts/test.js --env=jsdom", | ||
| "test-ci": "node scripts/test.js -- --runInBand --ci --testResultsProcessor=jest-junit", |
There was a problem hiding this comment.
not that it matters much but shouldn't these all work if calling npm run test?
dcramer
force-pushed
the
feat/js-coverage
branch
9 times, most recently
from
7985513
to
5a12942
Compare
|
dynamic-import-node being loaded outside of tests was causing weird behavior with our .less usage |
|
storybook's local presets is broken storybookjs/storybook#2635 |
|
lol i cant approve this i think that means that you can approve/merge billy |
billyvg
force-pushed
the
feat/js-coverage
branch
from
5619ae5
to
3f6470a
Compare
No description provided.