-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(issues): Use title from React caused errors #72593
Conversation
Starting with React 19, hydration errors include a `cause` error. Instead of using the hydration generic title we can use the title from the `cause` error. This makes all hydration errors titled differently, thus, being useful for investigation.
Why is this specific to React hydration errors? |
It would take more time to get the data to determine the extent of the impact of the change. I am currently investigating getting the data. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #72593 +/- ##
===========================================
+ Coverage 55.17% 78.05% +22.88%
===========================================
Files 6582 6596 +14
Lines 293476 293958 +482
Branches 50641 50705 +64
===========================================
+ Hits 161911 229440 +67529
+ Misses 127476 58261 -69215
- Partials 4089 6257 +2168
|
Makes sense. React uses |
@eps1lon - It's not always clear whether we want to use For lots more on this, see #64088 and the various issues it links to. |
Starting with React 19, errors can include a
cause
error. Instead of using the genericError
title, we can use the title from thecause
error, thus, making each issue unique.This design shows what the Issue Stream looks like now vs after this change: