fix(rules): Fix environment fetch #73665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
ceorourke
force-pushed
the
ceorourke/fix-env-fetch
branch
from
50b779a
to
b26fff3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #73665 +/- ##
===========================================
- Coverage 88.21% 78.07% -10.15%
===========================================
Files 2928 6652 +3724
Lines 182133 297331 +115198
Branches 32473 51166 +18693
===========================================
+ Hits 160677 232151 +71474
- Misses 15519 58870 +43351
- Partials 5937 6310 +373
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy/paste bug where the
.get()was on the wrong variable for the environment and was always returning None so if an environment was present on the rule and then was removed, it wouldn't be added to the confirmation notification. See https://github.com/getsentry/sentry/pull/66847/files#r1662799957