Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(browserHistory): Remove form actionSelector #82633

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ref(browserHistory): Remove form actionSelector #82633

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions static/app/views/insights/common/views/spans/selectors/actionSelector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@ import omit from 'lodash/omit';
import {CompactSelect} from 'sentry/components/compactSelect';
import {t} from 'sentry/locale';
import {trackAnalytics} from 'sentry/utils/analytics';
import {browserHistory} from 'sentry/utils/browserHistory';
import EventView from 'sentry/utils/discover/eventView';
import {DiscoverDatasets} from 'sentry/utils/discover/types';
import {EMPTY_OPTION_VALUE} from 'sentry/utils/tokenizeSearch';
import {useLocation} from 'sentry/utils/useLocation';
import {useNavigate} from 'sentry/utils/useNavigate';
import useOrganization from 'sentry/utils/useOrganization';
import {useSpansQuery} from 'sentry/views/insights/common/queries/useSpansQuery';
import {buildEventViewQuery} from 'sentry/views/insights/common/utils/buildEventViewQuery';
Expand All @@ -30,6 +30,7 @@ type Props = {
export function ActionSelector({value = '', moduleName, spanCategory, filters}: Props) {
// TODO: This only returns the top 25 actions. It should either load them all, or paginate, or allow searching
//
const navigate = useNavigate();
const location = useLocation();
const organization = useOrganization();
const eventView = getEventView(location, moduleName, spanCategory);
Expand Down Expand Up @@ -88,7 +89,7 @@ export function ActionSelector({value = '', moduleName, spanCategory, filters}:
source: moduleName,
value: newValue.value,
});
browserHistory.push({
navigate({
...location,
query: {
...location.query,
Expand Down
Loading