Skip to content

Commit

Permalink
Remove cargo update from version-bump script (#796)
Browse files Browse the repository at this point in the history
Looks like `minidump-processor` is now using symbolic as well. And we cannot bump the version
of its symbolic dependency because its an out-of-workspace package. `cargo update` in that case would
require the version to already exist in the registry.

Just remove the `cargo update`. We do not check in our lockfile so whatever updates it would do would never be committed anyway.
  • Loading branch information
Swatinem authored Jun 23, 2023
1 parent 2ac7fee commit 0cca339
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion scripts/bump-version
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,3 @@ echo "Bumping version: ${NEW_VERSION}"
TOML_FILES="$(git ls-files '*Cargo.toml')"
perl -pi -e "s/^version = .*\$/version = \"$NEW_VERSION\"/" $TOML_FILES
perl -pi -e "s/^(symbolic.*version = )\"[^\"]*\"/\\1\"$NEW_VERSION\"/" $TOML_FILES
cargo update -p symbolic --precise "${NEW_VERSION}"

0 comments on commit 0cca339

Please sign in to comment.