fix: Correctly read the debug_id of Deterministic PE files #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstange
reviewed
Aug 10, 2022
kamilogorek
approved these changes
Aug 10, 2022
loewenheim
approved these changes
Aug 17, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #658 +/- ##
=======================================
Coverage 73.80% 73.81%
=======================================
Files 69 69
Lines 14875 14876 +1
=======================================
+ Hits 10979 10980 +1
Misses 3896 3896 |
Deterministic PE files have a slightly different way of storing their `debug_id`, which should match the corresponding ID inside a portable pdb `#Pdb` stream. See https://github.com/dotnet/runtime/blob/main/docs/design/specs/PE-COFF.md#codeview-debug-directory-entry-type-2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deterministic PE files have a slightly different way of storing their debug_id, which
should match the corresponding ID inside a portable pdb
#Pdbstream.See https://github.com/dotnet/runtime/blob/main/docs/design/specs/PE-COFF.md#codeview-debug-directory-entry-type-2