fix: Write SourceMapCache to disk in cabi #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of holding the SourceMapCache buffer in memory when it is being used via the cabi/python bindings, write it to a tempfile which is automatically cleaned up when the SourceMapCache is dropped. This should reduce memory pressure and allow the OS to page that out.
mitsuhiko
approved these changes
Nov 18, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #711 +/- ##
==========================================
- Coverage 72.73% 72.72% -0.01%
==========================================
Files 92 92
Lines 18424 18426 +2
==========================================
+ Hits 13400 13401 +1
- Misses 5024 5025 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of holding the SourceMapCache buffer in memory when it is being used via the cabi/python bindings, write it to a tempfile which is automatically cleaned up when the SourceMapCache is dropped.
This should reduce memory pressure and allow the OS to page that out.