Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Remove demangling from C/Python bindings #730

Merged
merged 6 commits into from
Dec 6, 2022
Merged

ref: Remove demangling from C/Python bindings #730

merged 6 commits into from
Dec 6, 2022

Conversation

loewenheim
Copy link
Contributor

As discussed under #699.

TODO: The example in the readme involves demangling, what should we put there instead?

@loewenheim loewenheim self-assigned this Dec 5, 2022
Swatinem
Swatinem approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call, no idea though.

I would prefer if we stopped "advertising" cabi/python in the first place. Its a pain to maintain and people can easily generate their own bindings via bindgen or pyo3 or whatever the best approach nowadays is :-)

py/symbolic/symcache.py Outdated Show resolved Hide resolved
@loewenheim
Copy link
Contributor Author

Would you object to just removing the example?

@Swatinem
Copy link
Member

Swatinem commented Dec 5, 2022

Would you object to just removing the example?

I think thats a fair thing to do.

Swatinem
Swatinem approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls make sure to call this out as a breaking change in the changelog

@loewenheim loewenheim marked this pull request as ready for review December 5, 2022 14:46
@loewenheim loewenheim requested a review from a team December 5, 2022 14:46
@loewenheim loewenheim enabled auto-merge (squash) December 5, 2022 14:47
@loewenheim loewenheim merged commit 80ad25a into master Dec 6, 2022
@loewenheim loewenheim deleted the ref/remove-demangle branch December 6, 2022 07:28
@loewenheim loewenheim mentioned this pull request Jul 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swatinem Swatinem Swatinem approved these changes

Assignees

@loewenheim loewenheim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loewenheim @Swatinem