fix: Discard invalid line records and inlinees #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #747 +/- ##
=======================================
Coverage 73.43% 73.43%
=======================================
Files 69 69
Lines 14875 14885 +10
=======================================
+ Hits 10923 10931 +8
- Misses 3952 3954 +2 |
Swatinem
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #746, broken Breakpad files sometimes contain line records that start before the function they supposedly belong to. This PR discards those records when parsing functions. It also does the same for inlinees, although we haven't actually seen this happen.
Should we report this to the user somehow or is it ok to discard the records silently?