-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change DebugSession::source_by_path()
to return SourceCode
enum
#758
Merged
Merged
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
c1ffa98
refactor: change source_by_path to return SourceCode enum
vaind 9932e80
feat: ppdb source link mapping
vaind f78f5af
source link resolve() and tests
vaind 5d4f336
chore: remove todo
vaind 5e2e6b6
chore: minor changes
vaind aa72c59
chore: update changelog
vaind cdac4ab
chore: fixup docs link
vaind ce4bf58
Apply suggestions from code review
vaind f7c0a09
refactor SourceLinkMappings to build sorted
vaind 71f008c
formatting
vaind 18c8ac0
Update symbolic-ppdb/src/format/sourcelinks.rs
vaind 6f45b8f
Update symbolic-ppdb/src/format/sourcelinks.rs
vaind adf4cfe
chore: review changes
vaind 6aa003a
chore: review changes
vaind 2e13de8
chore: update imports
vaind f84cf69
tmp
vaind 6751263
test: switch source-link tests to a custom project
vaind 1bde15b
fix: add `#[non_exhaustive]` to SoureCode enum
vaind b947346
test: fix source-link tests on mac/linux
vaind File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
chore: review changes
- Loading branch information
commit adf4cfe872d30228ce1914f804572d23feb4f875
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe there is only ever one module as defined in the specification.