fix(ppdb): Parse streams in the correct order #760
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ppdb parsing incorrectly assumed that the
#Pdb
stream would always be physically located before the#~
stream and just parsed them in order. Since the#Pdb
stream contains table size information that must be known during#~
parsing, this led to the bug described in #759.The fix is simply to initially collect the locations of all the streams and then parse the
#Pdb
stream before the others.