fix(sourcemap): Improve scope name resolution #786
Conversation
|
See getsentry/sentry-dart#1430 for a case that should be fixed by this. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #786 +/- ##
==========================================
+ Coverage 74.99% 75.02% +0.03%
==========================================
Files 71 71
Lines 15570 15610 +40
==========================================
+ Hits 11676 11711 +35
- Misses 3894 3899 +5 |
| ctx.offset_to_position(range.end - 1).and_then(|sp| { | ||
| let token = sm.lookup_token(sp.line, sp.column); | ||
| token | ||
| .filter(|t| t.get_dst() == (sp.line, sp.column)) |
There was a problem hiding this comment.
We are looking for an exact token match at the closing } which is good. However in testing, we figured out that this trailing token is exactly 1 byte wide.
We could further filter this down to make sure that the token at range.end is a different token. I wonder how much that would change things though.
There was a problem hiding this comment.
Would it make sense to check for a literal closing brace?
There was a problem hiding this comment.
only partly. Sure, the end of an arrow function with an expression body would not have a closing }, however the case with dart is that it should only match that }, and the following token immediately afterwards was something different. I believe we should make this special-case as narrow as possible to avoid false positives.
We have seen cases in Flutter where a scope name cannot be resolved, but the scope's closing brace has the correct name attached. Therefore, if we can't resolve a scope name the straightforward way, we try to grab the name off the scope's last token.