feat(demangle): Update Swift demangler to Swift 5.10 #854
Conversation
fantexi023
changed the title
There was a problem hiding this comment.
Thank you for taking a look at this!
We have evidently not touched this code in quite a while, because updating it is quite cumbersome.
CI fails to compile with the updated code, but I can’t really make out what exactly the source of the problem is. Other than that, I added another comment related to a small patch that we applied to the swift code, which you should ideally carry forward.
| bool ShortenArchetype = false; | ||
| bool ShowPrivateDiscriminators = true; | ||
| bool ShowFunctionArgumentTypes = true; | ||
| + bool ShowFunctionReturnType = true; |
There was a problem hiding this comment.
You mentioned this in the changed swiftdemangle.cpp file. This option is indeed not part of upstream Swift, but we patched that in via this small patch here.
There was a problem hiding this comment.
Thank you for your reply.
I also saw that the CI process gave five errors, among which the problem of Rust Test on macos-latest should be that the SWIFT_STDLIB_HAS_TYPE_PRINTING did not take effect, which may be caused by the passing exception of CMakeLists.txt. I cancelled the restriction of SWIFT_STDLIB_HAS_TYPE_PRINTING this macro locally. The other four problems correspond to the same error, but I did not encounter this error on my own Mac.
There was a problem hiding this comment.
You mentioned this in the changed
swiftdemangle.cppfile. This option is indeed not part of upstream Swift, but we patched that in via this small patch here.
yeah, I do understand your explanation for ShowFunctionReturnType. TXS!
|
@fantexi023 Are you still working on this? |
No description provided.