Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sourcebundle): Add callback to handle skipped files #864

Merged
merged 4 commits into from
Sep 4, 2024
Merged

feat(sourcebundle): Add callback to handle skipped files #864

merged 4 commits into from
Sep 4, 2024

Commits on Aug 30, 2024

  1. feat(sourcebundle): Add callback to handle skipped files 

    Add a callback to SourceBundleWriter that is called every time we skip adding a file to the bundle due to a ReadFailed error.

Closes #863
    @szokeasaurusrex
    szokeasaurusrex committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    c343fb8 View commit details
    Browse the repository at this point in the history

  2. fix(sourcebundle): Skip all invalid sources 

    #861 missed another spot where the ReadFailed error can cause the write function to fail; this commit fixes that.

Fixes #860
    @szokeasaurusrex
    szokeasaurusrex committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    676940d View commit details
    Browse the repository at this point in the history

  3. meta: Update changelog

    @szokeasaurusrex
    szokeasaurusrex committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    d348055 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. apply suggestions from code review 

    Co-authored-by: Jan Michael Auer <jan.auer@sentry.io>
    @szokeasaurusrex @jan-auer
    szokeasaurusrex and jan-auer committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    6fb5a49 View commit details
    Browse the repository at this point in the history