Remove generated pipelines and update gocd-jsonnet (#1290)

.github/workflows/validate-pipelines.yml

@@ -27,22 +27,6 @@ jobs:
                   - 'gocd/**'
                   - '.github/workflows/validate-pipelines.yml'
 
-    render:
-        if: needs.files-changed.outputs.gocd == 'true'
-        needs: files-changed
-        name: Render GoCD Pipelines with Jsonnet
-        runs-on: ubuntu-latest
-        steps:
-          - uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c  # v3
-          - uses: getsentry/action-gocd-jsonnet@v1
-            with:
-              jb-install: true
-              check-for-changes: true
-              convert-to-yaml: true
-              jsonnet-dir: gocd/templates
-              generated-dir: gocd/generated-pipelines
-              render-as-single-file: false
-
     validate:
         if: needs.files-changed.outputs.gocd == 'true'
         needs: files-changed
@@ -67,10 +51,8 @@ jobs:
             - uses: getsentry/action-gocd-jsonnet@v1
               with:
                 jb-install: true
-                convert-to-yaml: true
                 jsonnet-dir: gocd/templates
                 generated-dir: gocd/generated-pipelines
-                render-as-single-file: true
             - uses: getsentry/action-validate-gocd-pipelines@v1
               with:
                 configrepo: symbolicator__master

.gitignore

@@ -21,4 +21,6 @@ site
 # New test snapshots
 *.snap.new
 
+# GoCD
 gocd/templates/vendor/
+gocd/generated-pipelines/

gocd/README.md

@@ -2,18 +2,25 @@
 
 Symbolicator pipelines are rendered using jsonnet.
 
+## Dependencies
+
+You'll need the following dependencies to build the pipelines:
+
+```sh
+brew install go-jsonnet jsonnet-bundler yq
+```
+
 ## Jsonnet
 
 You can render the jsonnet pipelines by running:
 
-```
+```sh
 make gocd
 ```
 
 This will clean, fmt, lint and generate the GoCD pipelines to
 `./gocd/generated-pipelines`.
 
-
 The pipelines are using the https://github.com/getsentry/gocd-jsonnet
 libraries to generate the pipeline for each region.
 
@@ -45,15 +52,5 @@ You can update jsonnet dependencies by runnning `jb update`.
 
 ### `gocd/generated-pipelines/`
 
-The current setup of GoCD at sentry is only able to look for
-yaml pipelines in a repo, so the genered pipelines have the be
-commited.
-
-The dev-infra team is working on a GoCD plugin that will accept
-the jsonnet directly, removing the need for commiting the
-generated-pipelines.
-
-### `gocd/pipelines/`
-
-These are the original pipelines and will be used until we move
-to the jsonnet pipelines.
+GoCD generates pipelines using the jsonnet files directly, hence why
+the generated pipelines are part of the gitignore.