ref: Update deps and remove dead-stores (#566)

crates/symbolicator/Cargo.toml

@@ -25,7 +25,7 @@ ipnetwork = "0.18.0"
 jsonwebtoken = "7.2.0"
 lazy_static = "1.4.0"
 log = { version = "0.4.13", features = ["serde"] }
-lru = "0.6.3"
+lru = "0.7.0"
 num_cpus = "1.13.0"
 minidump = "0.3"
 parking_lot = "0.11.1"

crates/symbolicator/src/services/cficaches.rs

@@ -87,10 +87,12 @@ impl CfiCacheActor {
 
 #[derive(Debug)]
 pub struct CfiCacheFile {
-    object_type: ObjectType,
-    identifier: ObjectId,
-    scope: Scope,
-    data: ByteView<'static>,
+    // NOTE: ideally this would keep the ByteView it could receive via CacheItemRequest::load
+    // however we only use this file by opening it by filename from a subprocess.  Until we can
+    // pass a filedescriptor to the subprocess instead of a filename there is no point in storing
+    // this ByteView and instead we only rely on the cache semantics of touching the mtime
+    // before returning a cache item to ensure the cleanup process will not remove this while
+    // we are using it.
     features: ObjectFeatures,
     status: CacheStatus,
     path: CachePath,
@@ -200,9 +202,9 @@ impl CacheItemRequest for FetchCfiCacheInternal {
 
     fn load(
         &self,
-        scope: Scope,
+        _scope: Scope,
         status: CacheStatus,
-        data: ByteView<'static>,
+        _data: ByteView<'static>,
         path: CachePath,
     ) -> Self::Item {
         let mut candidates = self.candidates.clone();
@@ -213,10 +215,6 @@ impl CacheItemRequest for FetchCfiCacheInternal {
         );
 
         CfiCacheFile {
-            object_type: self.request.object_type,
-            identifier: self.request.identifier.clone(),
-            scope,
-            data,
             features: self.meta_handle.features(),
             status,
             path,
@@ -270,10 +268,6 @@ impl CfiCacheActor {
                     .await
             }
             None => Ok(Arc::new(CfiCacheFile {
-                object_type: request.object_type,
-                identifier: request.identifier,
-                scope: request.scope,
-                data: ByteView::from_slice(b""),
                 features: ObjectFeatures::default(),
                 status: CacheStatus::Negative,
                 path: CachePath::new(),