Skip to content

Commit

Permalink
switch download error logging to debug
Browse files Browse the repository at this point in the history
  • Loading branch information
relaxolotl committed Aug 4, 2021
1 parent bd26c77 commit 5759eb0
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
6 changes: 3 additions & 3 deletions crates/symbolicator/src/services/download/gcs.rs
Original file line number Diff line number Diff line change
Expand Up @@ -257,15 +257,15 @@ impl GcsDownloader {
super::download_stream(source, stream, destination, timeout).await
// If it's a client error, chances are either it's a 404 or it's permission-related.
} else if response.status().is_client_error() {
log::trace!(
log::debug!(
"Unexpected client error status code from GCS {} (from {}): {}",
&key,
&bucket,
response.status()
);
Ok(DownloadStatus::NotFound)
} else {
log::trace!(
log::debug!(
"Unexpected status code from GCS {} (from {}): {}",
&key,
&bucket,
Expand All @@ -277,7 +277,7 @@ impl GcsDownloader {
}
}
Ok(Err(e)) => {
log::trace!(
log::debug!(
"Skipping response from GCS {} (from {}): {} ({:?})",
&key,
&bucket,
Expand Down
4 changes: 2 additions & 2 deletions crates/symbolicator/src/services/download/http.rs
Original file line number Diff line number Diff line change
Expand Up @@ -114,14 +114,14 @@ impl HttpDownloader {
super::download_stream(source, stream, destination, timeout).await
// If it's a client error, chances are either it's a 404 or it's permission-related.
} else if response.status().is_client_error() {
log::trace!(
log::debug!(
"Unexpected client error status code from {}: {}",
download_url,
response.status()
);
Ok(DownloadStatus::NotFound)
} else {
log::trace!(
log::debug!(
"Unexpected status code from {}: {}",
download_url,
response.status()
Expand Down
4 changes: 2 additions & 2 deletions crates/symbolicator/src/services/download/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -140,10 +140,10 @@ impl DownloadService {
Ok(status) => {
match status {
DownloadStatus::Completed => {
log::debug!("Did not fetch debug file from {:?}: {:?}", source, status);
log::debug!("Fetched debug file from {:?}: {:?}", source, status);
}
DownloadStatus::NotFound => {
log::debug!("Fetched debug file from {:?}: {:?}", source, status);
log::debug!("Did not fetch debug file from {:?}: {:?}", source, status);
}
};
Ok(status)
Expand Down
6 changes: 3 additions & 3 deletions crates/symbolicator/src/services/download/sentry.rs
Original file line number Diff line number Diff line change
Expand Up @@ -285,14 +285,14 @@ impl SentryDownloader {
super::download_stream(source, stream, destination, timeout).await
// If it's a client error, chances are either it's a 404 or it's permission-related.
} else if response.status().is_client_error() {
log::trace!(
log::debug!(
"Unexpected client error status code from {}: {}",
download_url,
response.status()
);
Ok(DownloadStatus::NotFound)
} else {
log::trace!(
log::debug!(
"Unexpected status code from {}: {}",
download_url,
response.status()
Expand All @@ -303,7 +303,7 @@ impl SentryDownloader {
}
}
Ok(Err(e)) => {
log::trace!("Skipping response from {}: {}", download_url, e);
log::debug!("Skipping response from {}: {}", download_url, e);
Err(DownloadError::Reqwest(e)) // must be wrong type
}
// Timed out
Expand Down

0 comments on commit 5759eb0

Please sign in to comment.