missed one type of s3 error that's a not found

getsentry · Jul 31, 2021 · 853d10d · 853d10d
1 parent c2cf4b2
commit 853d10d
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/crates/symbolicator/src/services/download/s3.rs b/crates/symbolicator/src/services/download/s3.rs
@@ -176,12 +176,13 @@ impl S3Downloader {
                 // - Otherwise, a 403 ("access denied") is returned.
                 log::debug!("Skipping response from s3://{}/{}: {}", bucket, &key, err);
 
-                if let RusotoError::Unknown(response) = &err {
-                    if response.status.is_client_error() {
-                        return Ok(DownloadStatus::NotFound);
+                match &err {
+                    RusotoError::Service(_) => return Ok(DownloadStatus::NotFound),
+                    RusotoError::Unknown(response) if response.status.is_client_error() => {
+                        return Ok(DownloadStatus::NotFound)
                     }
+                    _ => return Err(DownloadError::S3(err)),
                 }
-                return Err(DownloadError::S3(err));
             }
             Err(_) => {
                 // Timed out