Skip to content

Commit

Permalink
Add a metric for needed files per JS event
Browse files Browse the repository at this point in the history
  • Loading branch information
Swatinem committed Sep 29, 2023
1 parent 7ce9f63 commit 8bb6298
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions crates/symbolicator-service/src/js/metrics.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ use crate::types::ResolvedWith;
/// Various metrics we want to capture *per-event* for JS events.
#[derive(Debug, Default)]
pub struct JsMetrics {
pub needed_files: u64,
pub api_requests: u64,
pub queried_artifacts: u64,
pub fetched_artifacts: u64,
Expand Down Expand Up @@ -87,6 +88,7 @@ impl JsMetrics {
}

pub fn submit_metrics(&self, artifact_bundles: u64) {
metric!(time_raw("js.needed_files") = self.needed_files);
metric!(time_raw("js.api_requests") = self.api_requests);
metric!(time_raw("js.queried_bundles") = self.queried_bundles);
metric!(time_raw("js.fetched_bundles") = artifact_bundles);
Expand Down
2 changes: 2 additions & 0 deletions crates/symbolicator-service/src/services/sourcemap_lookup.rs
Original file line number Diff line number Diff line change
Expand Up @@ -714,6 +714,8 @@ impl ArtifactFetcher {
/// (because multiple files can share one [`DebugId`]).
#[tracing::instrument(skip(self))]
pub async fn get_file(&mut self, key: &FileKey) -> CachedFileEntry {
self.metrics.needed_files += 1;

if let Some(file) = self.try_get_file_using_index(key).await {
return file;
}
Expand Down

0 comments on commit 8bb6298

Please sign in to comment.