Remove manual insertion-sort from create_candidates
#1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `From` impl of `AllObjectCandidates` already sorts and dedupes, no need to do that manually via a custom insertion-sort.
loewenheim
approved these changes
Jul 14, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1254 +/- ##
==========================================
- Coverage 76.36% 76.33% -0.03%
==========================================
Files 85 85
Lines 14066 14061 -5
==========================================
- Hits 10742 10734 -8
- Misses 3324 3327 +3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Fromimpl ofAllObjectCandidatesalready sorts and dedupes, no need to do that manually via a custom insertion-sort.#skip-changelog