Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore outrageously large files from source bundles #1273

Merged
merged 4 commits into from
Sep 4, 2023
Merged

Ignore outrageously large files from source bundles #1273

merged 4 commits into from
Sep 4, 2023

Conversation

donalmacc
Copy link
Contributor

Fixes #1217 by ignoring PCH's

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #1273 (2573d52) into master (147e0e6) will decrease coverage by 3.19%.
Report is 4 commits behind head on master.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1273      +/-   ##
==========================================
- Coverage   76.79%   73.60%   -3.19%     
==========================================
  Files          87       88       +1     
  Lines       14295    14459     +164     
==========================================
- Hits        10978    10643     -335     
- Misses       3317     3816     +499     

@loewenheim
Copy link
Contributor

This still requires some linting fixes, and a changelog entry would be appreciated :)

@donalmacc
Copy link
Contributor Author

Hey and sorry about the delay here. I added a changelog entry (but I picked a version number, not sure what the norm is here).

Regarding the linting fixes, I'm happy to apply them, but I actually don't understand what the problem is. When I run cargo fmt --all -- --check locally it seems fine, and the link doesn't seem to show any errors, just the diff of my changes. I'm happy to change them if I can figure out what's wrong though.

@loewenheim
Copy link
Contributor

Can you try running cargo fmt --all (without --check) and see if it modifies anything?

@loewenheim loewenheim enabled auto-merge (squash) September 4, 2023 10:07
@loewenheim loewenheim merged commit d0246fa into getsentry:master Sep 4, 2023
12 checks passed
@donalmacc
Copy link
Contributor Author

Thanks for handling this, sorry. This has been on the backburner for me the last few weeks and I kept meaning to come back to it.

@loewenheim
Copy link
Contributor

No problem, thanks for making the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

symsorter performance issue generating source bundles for large PDB's
2 participants