-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore outrageously large files from source bundles #1273
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1273 +/- ##
==========================================
- Coverage 76.79% 73.60% -3.19%
==========================================
Files 87 88 +1
Lines 14295 14459 +164
==========================================
- Hits 10978 10643 -335
- Misses 3317 3816 +499 |
This still requires some linting fixes, and a changelog entry would be appreciated :) |
Hey and sorry about the delay here. I added a changelog entry (but I picked a version number, not sure what the norm is here). Regarding the linting fixes, I'm happy to apply them, but I actually don't understand what the problem is. When I run |
Can you try running |
Thanks for handling this, sorry. This has been on the backburner for me the last few weeks and I kept meaning to come back to it. |
No problem, thanks for making the PR! |
Fixes #1217 by ignoring PCH's