Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generated pipelines and update gocd-jsonnet #1290

Merged
merged 3 commits into from
Aug 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions .github/workflows/validate-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,22 +27,6 @@ jobs:
- 'gocd/**'
- '.github/workflows/validate-pipelines.yml'

render:
if: needs.files-changed.outputs.gocd == 'true'
needs: files-changed
name: Render GoCD Pipelines with Jsonnet
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@ac593985615ec2ede58e132d2e21d2b1cbd6127c # v3
- uses: getsentry/action-gocd-jsonnet@v1
with:
jb-install: true
check-for-changes: true
convert-to-yaml: true
jsonnet-dir: gocd/templates
generated-dir: gocd/generated-pipelines
render-as-single-file: false

validate:
if: needs.files-changed.outputs.gocd == 'true'
needs: files-changed
Expand All @@ -67,10 +51,8 @@ jobs:
- uses: getsentry/action-gocd-jsonnet@v1
with:
jb-install: true
convert-to-yaml: true
jsonnet-dir: gocd/templates
generated-dir: gocd/generated-pipelines
render-as-single-file: true
- uses: getsentry/action-validate-gocd-pipelines@v1
with:
configrepo: symbolicator__master
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,6 @@ site
# New test snapshots
*.snap.new

# GoCD
gocd/templates/vendor/
gocd/generated-pipelines/
25 changes: 11 additions & 14 deletions gocd/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,25 @@

Symbolicator pipelines are rendered using jsonnet.

## Dependencies

You'll need the following dependencies to build the pipelines:

```sh
brew install go-jsonnet jsonnet-bundler yq
```

## Jsonnet

You can render the jsonnet pipelines by running:

```
```sh
make gocd
```

This will clean, fmt, lint and generate the GoCD pipelines to
`./gocd/generated-pipelines`.


The pipelines are using the https://github.com/getsentry/gocd-jsonnet
libraries to generate the pipeline for each region.

Expand Down Expand Up @@ -45,15 +52,5 @@ You can update jsonnet dependencies by runnning `jb update`.

### `gocd/generated-pipelines/`

The current setup of GoCD at sentry is only able to look for
yaml pipelines in a repo, so the genered pipelines have the be
commited.

The dev-infra team is working on a GoCD plugin that will accept
the jsonnet directly, removing the need for commiting the
generated-pipelines.

### `gocd/pipelines/`

These are the original pipelines and will be used until we move
to the jsonnet pipelines.
GoCD generates pipelines using the jsonnet files directly, hence why
the generated pipelines are part of the gitignore.
43 changes: 0 additions & 43 deletions gocd/generated-pipelines/rollback-symbolicator.yaml

This file was deleted.

83 changes: 0 additions & 83 deletions gocd/generated-pipelines/symbolicator-customer-1.yaml

This file was deleted.

83 changes: 0 additions & 83 deletions gocd/generated-pipelines/symbolicator-customer-2.yaml

This file was deleted.

83 changes: 0 additions & 83 deletions gocd/generated-pipelines/symbolicator-customer-3.yaml

This file was deleted.

Loading
Loading