Add metrics to stresstest and optimize cadence usage
#1360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added a local UDP sink to fully test metrics submission. It turns out the default `cadence` sink and the UDP submissions it does are *extremely* slow (at least on my machine). Switching to the queueing and buffering sink speeds up the stresstest considerably. ``` Workload 0 (concurrency: 10): 176 operations, 11.733334 ops/s Workload 1 (concurrency: 10): 137 operations, 9.133333 ops/s Workload 2 (concurrency: 10): 190 operations, 12.666667 ops/s Workload 3 (concurrency: 100): 169 operations, 11.266666 ops/s Workload 4 (concurrency: 100): 388 operations, 25.866667 ops/s Workload 5 (concurrency: 50): 563 operations, 37.533333 ops/s Workload 0 (concurrency: 10): 2613 operations, 174.2 ops/s Workload 1 (concurrency: 10): 1978 operations, 131.86667 ops/s Workload 2 (concurrency: 10): 3681 operations, 245.4 ops/s Workload 3 (concurrency: 100): 21564 operations, 1437.6 ops/s Workload 4 (concurrency: 100): 10633 operations, 708.86664 ops/s Workload 5 (concurrency: 50): 20848 operations, 1389.8667 ops/s ``` That is a 10x-100x improvement depending on the stresstest.
loewenheim
reviewed
Feb 5, 2024
loewenheim
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a local UDP sink to fully test metrics submission. It turns out the default
cadencesink and the UDP submissions it does are extremely slow (at least on my machine).Switching to the queueing and buffering sink speeds up the stresstest considerably.
That is a 10x-100x improvement depending on the stresstest.
#skip-changelog