Hook up Sentry Metrics to Metrics Aggregator #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated alternative to #1351
It is now integrated into the metrics aggregator, and sends Sentry metrics from there.
The performance impact is quite visible in the flamegraphs, but overall numbers do not look that bad.
It is a bit unfortunate that the Sentry API expects
Cow<'static, str>, which pretty much means incurringStringallocations for this all the time, which is quite inefficient, but does not seem to hurt performance that much.I would say this is ready to be tested in canary.