feat(proguard): Remap filename and abs_path #1432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
approved these changes
Apr 9, 2024
loewenheim
changed the title
anonrig
approved these changes
Apr 9, 2024
| let deobfuscated_signature = frame.signature.as_ref().and_then(|signature| { | ||
| mappers | ||
| .iter() | ||
| .find_map(|mapper| mapper.deobfuscate_signature(signature)) |
loewenheim
force-pushed
the
feat/proguard-filenames
branch
from
1ebfba1
to
14087f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just applies the file name returned by the proguard mapper, if any, to the filename and abs path.
This is actually done, I'm just making it a draft because I don't want to merge it before we're done with our A/B testing.
Closes https://github.com/getsentry/team-ingest/issues/396.