Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making performance trace sample rate configurable #1517

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Conversation

tobias-wilfert
Copy link
Member

@tobias-wilfert tobias-wilfert commented Sep 12, 2024

Addressing: #1515 still some todo's that need to be tackled but opened to invite feedback.

TODO's:

  • Find a way to write some tests for this (or none if deemed not necessary)
  • Discuss if the documentation is sufficient
  • Discuss if the variable naming is intuitive and what to do with the now 'out-dated' comment

@tobias-wilfert tobias-wilfert self-assigned this Sep 12, 2024
Copy link
Contributor

@loewenheim loewenheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I think tests aren't necessary for this, but it could use a changelog entry.

crates/symbolicator/src/cli.rs Outdated Show resolved Hide resolved
@tobias-wilfert tobias-wilfert changed the title WIP: Making performance trace sample rate configurable Making performance trace sample rate configurable Sep 12, 2024
@tobias-wilfert tobias-wilfert merged commit 8b11255 into master Sep 12, 2024
13 checks passed
@tobias-wilfert tobias-wilfert deleted the sample-rate branch September 12, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants