-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add an option to configure subprocess pool size #273
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will also need to update this here, which creates our standard thread pools:
symbolicator/src/utils/futures.rs
Line 53 in 2cad3b1
let runtime = tokio::runtime::Builder::new().build().unwrap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, meant to request changes.
@jan-auer you sure we want to have one setting for everything? Technically, there's also a worker pool in actix HttpServer where we can also adjust worker count |
That's a good question. We may want to split this, indeed. Some of these thread pools used to perform CPU-intensive work, but do no longer due to subprocessing. So in that case, we may consider to dial them down independently, so I think your patch is fine. Should we maybe clarify in docs then that this is the number of sub processes? |
@jan-auer updated the docstring, but in the docs we already have this: |
This can be useful when Symbolicator is not the only service running on the machine (e.g. in Kubernetes environment).